fix(review-filter): apply language for review filter stage#297
fix(review-filter): apply language for review filter stage#297ScarletCarpet wants to merge 1 commit into
Conversation
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
|
Thanks a lot for digging into the review-filter behavior, @ScarletCarpet — it's a genuinely subtle area and the change itself is clean (nice nil-guard and test coverage). 🙏 After looking closely, though, I don't think this is the right layer for the fix, so I'm going to close it. Here's the reasoning: The review-filter output is a machine-parsed control signal, not user-facing text. The prompt asks the model to return a bare JSON array of comment IDs, and the consumer ( Because of that, injecting
Contrast with Overlap with #295: that PR moves the filter to function calling specifically to stop models from emitting natural language. This change pushes in the opposite direction, so if #295 lands the language directive becomes moot anyway. If the real symptom is chatty models breaking the parse, the more robust fixes are the function-calling approach in #295 or more lenient JSON extraction inside Thanks again for the contribution and for the careful tests — really appreciate the effort here! |
Description
the review filter stage was not respond in
languagefor some model who deny the rule ofwithout any explanationType of Change
How Has This Been Tested?
make testpasses locallyChecklist
go fmt,go vet)Related Issues